Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support FOR_MIGRATION InternalRange objects #2896

Conversation

modular-magician
Copy link
Collaborator

Support for for-migration InternalRange resources.

A new value of usage enum is introduced: FOR_MIGRATION. Such ranges must also contain a nested object consisting of 2 strings: source - an URI/path to the migration source (a subnet resource being migrated, in its original location) and a target - an URI/path for the planned future resource (a subnet) to be recreated in the new location.

Fixes hashicorp/terraform-provider-google#19636

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: added field `migration` to resource `google_network_connectivity_internal_range`

Derived from GoogleCloudPlatform/magic-modules#11856

[upstream:b6675939e5afa0113e79ec31076c93d7021adc46]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician requested a review from a team as a code owner October 4, 2024 18:03
@modular-magician modular-magician requested review from roaks3 and removed request for a team October 4, 2024 18:03
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@modular-magician modular-magician merged commit 4a87264 into GoogleCloudPlatform:main Oct 4, 2024
2 of 3 checks passed
@modular-magician modular-magician deleted the downstream-pr-b6675939e5afa0113e79ec31076c93d7021adc46 branch November 18, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for usage=FOR_MIGRATION InternalRange resources to networkconnectivity product
1 participant