Add plan-time validation of name on google_compute_instance
#2984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Cameron Thornton <[email protected]> [upstream:4f8bd9304149a31b696139ce9c5086f3b42e00b9] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
iyabchen
and removed request for
a team
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
merged commit 72b9c7f
into
GoogleCloudPlatform:main
4 of 6 checks passed
modular-magician
deleted the
downstream-pr-4f8bd9304149a31b696139ce9c5086f3b42e00b9
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes hashicorp/terraform-provider-google#18265
google_compute_instanceThe regexes are wrong in the validation file. Our verification functions expected 2-63 characters when in reality it's 1-63. Basing on this documentation: https://cloud.google.com/compute/docs/naming-resources#resource-name-format and manual testing
Some other tests might fail due to these changes in the validate file so pls paste the test errors after the CICD run
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11886