Migrate google_compute_firewall_policy_association resource from DCL to MMv1 #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to MMv1 (#11358) Co-authored-by: Zhenhua Li <[email protected]> [upstream:3850a583f7d4839598b5bd5e73bbb3163df398c8] Signed-off-by: Modular Magician <[email protected]>
modular-magician
requested review from
melinath
and removed request for
a team
modular-magician
merged commit 3f50bc8
into
GoogleCloudPlatform:main
4 of 5 checks passed
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
modular-magician
deleted the
downstream-pr-3850a583f7d4839598b5bd5e73bbb3163df398c8
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks.
This PR is to move the Firewall Policy Association (
google_compute_firewall_policy_association) resource from DCL to MMv1. And this PR includes:Note: This PR doesn't include the deletion of the DCL resource. This change will be done on the Delarative Resource Client Library repository.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#11358