Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI based on 'maturin generate-ci' #3

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

djmitche
Copy link
Collaborator

@djmitche djmitche commented Dec 24, 2024

This adds a simple CI workflow, so we can check that tests are still passing, etc.

@djmitche djmitche force-pushed the add-ci branch 3 times, most recently from 1dbe69f to 9343310 Compare December 24, 2024 22:21
@djmitche
Copy link
Collaborator Author

@illya-laifu any idea what's up here? I asked a Q&A in PyO3/maturin#2412.

@illya-laifu
Copy link
Collaborator

According to the linked Github issue in the error:

FYI, if you ended up here because your Github Action reported your Python version (e.g. 3.8) was not compatible with a GIL-free build of Python, check your configuration of the requires-python of your pyproject.toml file and make sure it's 3.9 or above.

So all that has to be done, is this:
python = ">=3.8"

has to be bumped to 3.9 or higher.

Copy link
Collaborator

@illya-laifu illya-laifu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad the solution was just this simple 👌

@djmitche djmitche merged commit c7988a3 into GothenburgBitFactory:master Dec 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants