Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support permalinks with trailing slash removed #1495

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Feb 19, 2024

Description

Resolves #1489 (although we didn't have a problem accessing signed PDF URLs under this configuration)

Testing instructions

  1. Enable Pretty Permalinks in the WordPress settings
  2. Remove the trailing / from the custom permalinks section
  3. View a PDF from the admin area

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Resolves #1489 (although we didn't have a problem accessing signed PDF URLs under this configuration)
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (807bc8e) 75.19% compared to head (5b4381b) 93.30%.

Additional details and impacted files
@@                Coverage Diff                 @@
##             development    #1495       +/-   ##
==================================================
+ Coverage          75.19%   93.30%   +18.11%     
==================================================
  Files                243       57      -186     
  Lines              12939     1464    -11475     
  Branches             370      370               
==================================================
- Hits                9729     1366     -8363     
+ Misses              3202       90     -3112     
  Partials               8        8               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit f8857e2 into development Feb 19, 2024
15 of 18 checks passed
@jakejackson1 jakejackson1 deleted the pdf-trailingslash branch February 19, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use user_trailingslashit function when building PDF URL
1 participant