Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve license activation messages #1496

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Feb 20, 2024

Description

TODO:

  • Unit tests
  • Update GravityPDF.com and return the license ID in the response

This PR:

  • Adds more descriptive text when an activation error occurs.
  • Include specific actions to help users get their licenses activated correctly.
  • Allow activation on sites marked as non-production

Testing instructions

Install a paid Gravity PDF extension and then test the following:

  1. Activate an active license
  2. Activate an expired license
  3. Activate a disabled license
  4. Activate a license that has reached its site limit

Screenshots

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 76.04167% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 77.03%. Comparing base (f27ba77) to head (446897a).

Files Patch % Lines
src/Helper/Helper_Abstract_Addon.php 44.73% 21 Missing ⚠️
src/Helper/Helper_Abstract_Options.php 0.00% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1496      +/-   ##
===============================================
- Coverage        77.03%   77.03%   -0.01%     
===============================================
  Files              243      243              
  Lines            12447    12509      +62     
  Branches           370      370              
===============================================
+ Hits              9589     9636      +47     
- Misses            2850     2865      +15     
  Partials             8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 linked an issue Feb 20, 2024 that may be closed by this pull request
@jakejackson1 jakejackson1 force-pushed the license-key-error-improvements branch 2 times, most recently from 2035e28 to d83cf74 Compare February 26, 2024 03:32
@jakejackson1 jakejackson1 force-pushed the license-key-error-improvements branch from d83cf74 to 446897a Compare February 26, 2024 04:02
@jakejackson1 jakejackson1 merged commit c7b7dcb into development Feb 26, 2024
15 of 16 checks passed
@jakejackson1 jakejackson1 deleted the license-key-error-improvements branch February 26, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Licensing Process
1 participant