Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error savings forms in Gravity Forms 2.6 #1497

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jakejackson1
Copy link
Member

@jakejackson1 jakejackson1 commented Feb 23, 2024

Description

The \GFFormsModel::get_form_cache_key( $form_id ) method wasn't introduced until v2.7, and this was causing a fatal error in Gravity Forms 2.6 when saving the form in the editor.

Checklist:

  • I've tested the code.
  • My code is easy to read, follow, and understand
  • My code follows the accessibility standards.
  • My code has proper inline documentation / docblocks.

Additional Comments

Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.03%. Comparing base (c069c6e) to head (551020e).

Files Patch % Lines
src/Controller/Controller_Form_Settings.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1497      +/-   ##
===============================================
+ Coverage        77.02%   77.03%   +0.01%     
===============================================
  Files              243      243              
  Lines            12449    12447       -2     
  Branches           370      370              
===============================================
  Hits              9589     9589              
+ Misses            2852     2850       -2     
  Partials             8        8              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakejackson1 jakejackson1 merged commit b9d16b6 into development Feb 23, 2024
17 of 18 checks passed
@jakejackson1 jakejackson1 deleted the old-gf-version-php-error branch February 23, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant