PDF Cache #1540
PDF Cache #1540
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## development #1540 +/- ##
===============================================
- Coverage 76.07% 73.81% -2.27%
===============================================
Files 248 193 -55
Lines 12993 11620 -1373
Branches 370 0 -370
===============================================
- Hits 9885 8577 -1308
+ Misses 3100 3043 -57
+ Partials 8 0 -8 ☔ View full report in Codecov by Sentry. |
jakejackson1
force-pushed
the
pdf-cache
branch
2 times, most recently
from
0b1033e to
52b541f
Compare
| * | ||
| * @since 6.11.0 | ||
| */ | ||
| public function queue_cleanup_task( $form, $entry ) { |
There was a problem hiding this comment.
@jakejackson1 re-add and deprecate.
| @@ -874,13 +880,9 @@ protected function load_html( $args = [] ) { | |||
| */ | |||
| protected function maybe_display_raw_html( $html ) { | |||
|
|
|||
| /* @TODO - move to shared file */ | |||
There was a problem hiding this comment.
@jakejackson1 make you use rgget( 'html' ) && Debug::is_enabled_and_can_view()
| $settings = $this->apply_backwards_compatibility_filters( $settings, $entry ); | ||
| /* | ||
| * Normalize the PDF action | ||
| * The PDF cache introduced in 6.12 relies on a hash generated from the form, entry, and pdf settings |
There was a problem hiding this comment.
@jakejackson1 Add more info about editing the form, entry or PDF settings auto-expires a PDF so the document is always fresh.
api.php
Outdated
| * | ||
| * @since 6.12 | ||
| */ | ||
| public static function get_pdf_filename( $entry_id, $pdf_id, bool $include_extension ) { |
There was a problem hiding this comment.
@jakejackson1 move to another PR. Not required here.
Will also add an API for getting the field markup for a PDF.
| */ | ||
| class Cache { | ||
|
|
||
| protected static $template_tmp_location = null; |
There was a problem hiding this comment.
@jakejackson1 add docblocks
src/Statics/Debug.php
Outdated
|
|
||
| /** | ||
| * @since 6.12.0 | ||
| * @TODO |
There was a problem hiding this comment.
@jakejackson1 add docblocks
|
Superseded by #1556 |
Description
WIP.
PR to resolve #1539
Notes to self:
Testing instructions
Screenshots
Checklist:
Additional Comments