-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unnecessary rerendering of MessageTableEntry
component.
#19899
Merged
linuspahl
merged 16 commits into
master
from
fix/avoid-rerendering-of-message-table-entry
Jul 18, 2024
Merged
Avoid unnecessary rerendering of MessageTableEntry
component.
#19899
linuspahl
merged 16 commits into
master
from
fix/avoid-rerendering-of-message-table-entry
Jul 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
836412b
to
a295e76
Compare
a295e76
to
b11e7e1
Compare
linuspahl
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is based on #19896 which should be merged first.
Description
Motivation and Context
Prior to this PR, the
MessageTableEntry
component was rerendered whenever the route changes, due to using theuseLocation
hook. This can result in unnecessary rerenders. As this is used only for telemetry and therefore is relevant only at telemetry submission, this PR is pushing the retrieval of the current route to the actual telemetry submission function./nocl No user-facing change.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: