Fixing up events aggregation integration test. #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
fix/events-search-aggregation-test
branch
from
722597b to
c2fa3c4
Compare
janheise
reviewed
Aug 14, 2024
| @@ -36,7 +36,7 @@ | |||
| import java.util.List; | |||
| import java.util.concurrent.ExecutionException; | |||
|
|
|||
| @ContainerMatrixTestsConfiguration(serverLifecycle = Lifecycle.CLASS, searchVersions = {SearchServer.ES7, SearchServer.OS2_LATEST, SearchServer.DATANODE_DEV}, withWebhookServerEnabled = true) | |||
| @ContainerMatrixTestsConfiguration(serverLifecycle = Lifecycle.CLASS, searchVersions = {SearchServer.OS2_LATEST}, withWebhookServerEnabled = true) | |||
There was a problem hiding this comment.
what's the reason to only test with OS2_LATEST ?
|
|
||
| public record Deflector(String target, boolean isUp) {} | ||
|
|
||
| public Deflector deflector(String indexSetId) { |
There was a problem hiding this comment.
this is not used. do we want to keep it?
janheise
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is fixing the test introduced in #20154 so it tests also without a grouping, which triggers some issues with OS 2.16.0. It turns the existing test case with a grouping into an additional test case.
/nocl
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: