Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing highlighting of message in message table by id. (6.0) #21391

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

dennisoelkers
Copy link
Member

Note: This is a backport of #21389 to 6.0.

Description

Motivation and Context

This PR is fixing message highlighting by id in the message table, e.g. when using the "Show surrounding messages" functionality.
Previously, the css function was used inline, which generated invalid css for the left border color.

Fixes #19058.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers merged commit 7ec0f14 into 6.0 Jan 21, 2025
7 checks passed
@dennisoelkers dennisoelkers deleted the fix/issue-19058-6.0 branch January 21, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants