Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set unit settings to undefined on clear unit type 6.1 #21405

Conversation

maxiadlovskii
Copy link
Contributor

@maxiadlovskii maxiadlovskii commented Jan 22, 2025

Note: This is a backport of #21399 to 6.1

Description

This PR set unit settings to undefined on clear unit type. In this case instead of empty object we send undefined to BE and that fix an issue

Motivation and Context

fix: #21398

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers merged commit 2a854ca into 6.1 Jan 22, 2025
10 checks passed
@dennisoelkers dennisoelkers deleted the fix/issue-when-try-to-save-widget-without-a-unit/issue-21398-6.1 branch January 22, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants