Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase tolerance in pwmType #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

plger
Copy link

@plger plger commented Jan 24, 2024

motifmatchr fails when using some motifs collections (e.g. https://doi.org/10.1093/nar/gkad1240 ) due to small rounding errors in the column sums of the PFM preventing pwmType from determining whether the motifs are PFM or PWM. While it would be possible to process the matrices to avoid this, it's actually not that trivial and unnecessary, because the problem is easily solved by increasing the tolerance in pwmType.
There's also no drawback in doing so, given that it's virtually impossible that all the colSums of all PWM are by chance within 0.99-1.01.

to avoid errors due to rounding imprecision
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant