Improve Packet Handling #2704
Open
Improve Packet Handling #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Improves packet system for initial sync data allowing for the creation of sub-buffers to enforce data separation when necessary, allowing for improved logging of read/write mismatches.
Implementation Details
Introduces the
AdvancedPacketBufferclass, which extendsPacketBufferwhile additionally containing logic for creating and managing sub-buffers from an original buffer.Outcome
Allow for data separation & improved logging of when packets are not fully read.
Also allows for future functionality to be added to packet buffers in the future, since now our packet buffers will be part of our code base.
Additional Information
Addresses the same problem as #2703 but without sacrificing logging functionality.