Skip to content

Commit

Permalink
github readme updates to art
Browse files Browse the repository at this point in the history
  • Loading branch information
GregTrevellick committed May 9, 2017
1 parent 58aa0ba commit faaa695
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 28 deletions.
25 changes: 15 additions & 10 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,21 @@ Software License is available [here](/LICENSE.txt).

---------------------------------------

[![Altova Xml Spy](src/OpenInAltovaXmlSpy/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInAltovaXmlSpy/README.md)
[![Gimp](src/OpenInGimp/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInGimp/README.md)
[![Markdown Monster](src/OpenInMarkdownMonster/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInMarkdownMonster/README.md)
[![Paint Dot Net](src/OpenInPaintDotNet/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInPaintDotNet/README.md)
[![Visual Studio 2012](src/OpenInVS2012/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2012/README.md)
[![Visual Studio 2013](src/OpenInVS2013/Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2013/README.md)
[![Visual Studio 2015](src/OpenInVS2015//Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2015/README.md)
[![Visual Studio 2017 Community](src/OpenInVS2017Community//Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2017Community/README.md)
[![Visual Studio 2017 Enterprise](src/OpenInVS2017Enterprise//Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2017Enterprise/README.md)
[![Visual Studio 2017 Professional](src/OpenInVS2017Professional//Resources/VsixExtensionIcon_90x90.png)](src/OpenInApp.Assets/OpenInVS2017Professional/README.md)
[![Altova Xml Spy](src/OpenInApp.Assets/OpenInAltovaXmlSpy/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninAltovaXMLSpy)
[![Gimp](src/OpenInApp.Assets/OpenInGimp/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninGimp)
[![Markdown Monster](src/OpenInApp.Assets/OpenInMarkdownMonster/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninMarkdownMonster)
[![Paint Dot Net](src/OpenInApp.Assets/OpenInPaintDotNet/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninPaintDotNet)
[![Visual Studio 2012](src/OpenInVS2012/Resources/VsixExtensionIcon_90x90.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2012)
[![Visual Studio 2013](src/OpenInVS2013/Resources/VsixExtensionIcon_90x90.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2013)
[![Visual Studio 2015](src/OpenInVS2015//Resources/VsixExtensionIcon_90x90.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2015)
[![Visual Studio 2017 Community](src/OpenInApp.Assets/OpenInVS2017Community/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2017Community)
[![Visual Studio 2017 Enterprise](src/OpenInVS2017Enterprise//Resources/VsixExtensionIcon_90x90.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2017Enterprise)
[![Visual Studio 2017 Professional](src/OpenInVS2017Professional//Resources/VsixExtensionIcon_90x90.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVS2017Professional)
[![Vivaldi](src/OpenInApp.Assets/OpenInVivaldi/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninVivaldi)
[![Chrome Canary](src/OpenInApp.Assets/OpenInChromeCanary/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninChromeCanary)
[![Opera](src/OpenInApp.Assets/OpenInOpera/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninOpera)
[![Opera Developer](src/OpenInApp.Assets/OpenInOperaDeveloper/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninOperaDeveloper)
[![Firefox Developer Edition](src/OpenInApp.Assets/OpenInFirefoxDeveloperEdition/ThirdPartyLogo.png)](https://marketplace.visualstudio.com/items?itemName=GregTrevellick.OpeninFirefoxDeveloperEdition)

## Legal

Expand Down
22 changes: 4 additions & 18 deletions src/OpenInApp.Common.Tests/Helpers/OpenInAppHelperTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ public void InvokeCommandTest_TextApps(string executableFullPath, bool separateP
[Test()]
[Category("I")]
//TESTED & LIVE [TestCase(@"C:\Users\greg\AppData\Local\Vivaldi\Application\vivaldi.exe", null)]
//HAPPILY OPENS BOTH FILES [TestCase(@"C:\Program Files (x86)\Opera\opera.exe", null)]
//HAPPILY OPENS BOTH FILES [TestCase(@"C:\Program Files\Opera developer\launcher.exe", null)]
//HAPPILY OPENS BOTH FILES [TestCase(@"C:\Program Files\Firefox Developer Edition\firefox.exe", null)]//(aurora)
//HAPPILY OPENS BOTH FILES [TestCase(@"C:\Users\greg\AppData\Local\Google\Chrome SxS\Application\chrome.exe", null)]//(canary)
//TESTED & LIVE [TestCase(@"C:\Program Files (x86)\Opera\opera.exe", null)]
//TESTED & LIVE [TestCase(@"C:\Program Files\Opera developer\launcher.exe", null)]
//TESTED & LIVE [TestCase(@"C:\Program Files\Firefox Developer Edition\firefox.exe", null)]//(aurora)
//TESTED & LIVE [TestCase(@"C:\Users\greg\AppData\Local\Google\Chrome SxS\Application\chrome.exe", null)]//(canary)
//works with 2 files, 1 browser window 2 tabs but opens canary [TestCase(@"C:\Program Files (x86)\Google\Chrome\Application\chrome.exe", null)]
//works with 2 files, 1 browser window 2 tabs but opens aurora [TestCase(@"C:\Program Files (x86)\Mozilla Firefox\firefox.exe", null)]
//works but ignores the args, when 2 argsat least [TestCase(@"C:\Program Files (x86)\Internet Explorer\iexplore.exe", null)]
Expand Down Expand Up @@ -172,20 +172,6 @@ public void InvokeCommandTest_TODOCategory(string executableFullPath, bool useSh
Act(actualFilesToBeOpened, executableFullPath, separateProcessPerFileToBeOpened, useShellExecute);
}

////////////////////////////////////////////////////private void Act(IEnumerable<string> actualFilesToBeOpened, string executableFullPath, bool? separateProcessPerFileToBeOpened, bool? useShellExecute)
////////////////////////////////////////////////////{
//////////////////////////////////////////////////// if (!separateProcessPerFileToBeOpened.HasValue && !useShellExecute.HasValue)
//////////////////////////////////////////////////// {
//////////////////////////////////////////////////// OpenInAppHelper.InvokeCommand(actualFilesToBeOpened, executableFullPath);
//////////////////////////////////////////////////// }
//////////////////////////////////////////////////// else
//////////////////////////////////////////////////// {
//////////////////////////////////////////////////// OpenInAppHelper.InvokeCommand(actualFilesToBeOpened, executableFullPath,
//////////////////////////////////////////////////// separateProcessPerFileToBeOpened.HasValue ? separateProcessPerFileToBeOpened.Value : false,
//////////////////////////////////////////////////// useShellExecute.HasValue ? useShellExecute.Value : true);
//////////////////////////////////////////////////// }
////////////////////////////////////////////////////}

private void Act(IEnumerable<string> actualFilesToBeOpened, string executableFullPath, bool separateProcessPerFileToBeOpened, bool useShellExecute)
{
OpenInAppHelper.InvokeCommand(actualFilesToBeOpened, executableFullPath, separateProcessPerFileToBeOpened, useShellExecute);
Expand Down

0 comments on commit faaa695

Please sign in to comment.