Skip to content

Commit

Permalink
test[next]: enable gpu test for 1d scan on dace backend (#1854)
Browse files Browse the repository at this point in the history
The dace backend did not support the case of scan on a 1D vertical
array, when lowered to GPU code. After upgrading the dace package to
latest main and adopting the `LoopRegion` construct for the lowering of
scan, this case is no longer an issue. This PR just re-enables the scan
test case.
  • Loading branch information
edopao authored Feb 11, 2025
1 parent 05b3b87 commit 3be5064
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 13 deletions.
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,6 @@ markers = [
'uses_reduction_with_only_sparse_fields: tests that require backend support for with sparse fields',
'uses_scalar_in_domain_and_fo',
'uses_scan: tests that uses scan',
'uses_scan_1d_field: that that uses scan on 1D vertical field',
'uses_scan_in_field_operator: tests that require backend support for scan in field operator',
'uses_scan_in_stencil: tests that require backend support for scan in stencil',
'uses_scan_without_field_args: tests that require calls to scan that do not have any fields as arguments',
Expand Down
13 changes: 2 additions & 11 deletions tests/next_tests/definitions.py
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ class ProgramFormatterId(_PythonObjectIdMixin, str, enum.Enum):
USES_SCAN_WITHOUT_FIELD_ARGS = "uses_scan_without_field_args"
USES_SCAN_NESTED = "uses_scan_nested"
USES_SCAN_REQUIRING_PROJECTOR = "uses_scan_requiring_projector"
USES_SCAN_1D_FIELD = "uses_scan_1d_field"
USES_SPARSE_FIELDS = "uses_sparse_fields"
USES_SPARSE_FIELDS_AS_OUTPUT = "uses_sparse_fields_as_output"
USES_REDUCTION_WITH_ONLY_SPARSE_FIELDS = "uses_reduction_with_only_sparse_fields"
Expand Down Expand Up @@ -190,17 +189,9 @@ class ProgramFormatterId(_PythonObjectIdMixin, str, enum.Enum):
EmbeddedIds.NUMPY_EXECUTION: EMBEDDED_SKIP_LIST,
EmbeddedIds.CUPY_EXECUTION: EMBEDDED_SKIP_LIST,
OptionalProgramBackendId.DACE_CPU: DACE_SKIP_TEST_LIST,
OptionalProgramBackendId.DACE_GPU: DACE_SKIP_TEST_LIST
+ [
# dace issue https://github.com/spcl/dace/issues/1773
(USES_SCAN_1D_FIELD, XFAIL, UNSUPPORTED_MESSAGE),
],
OptionalProgramBackendId.DACE_GPU: DACE_SKIP_TEST_LIST,
OptionalProgramBackendId.DACE_CPU_NO_OPT: DACE_SKIP_TEST_LIST,
OptionalProgramBackendId.DACE_GPU_NO_OPT: DACE_SKIP_TEST_LIST
+ [
# dace issue https://github.com/spcl/dace/issues/1773
(USES_SCAN_1D_FIELD, XFAIL, UNSUPPORTED_MESSAGE),
],
OptionalProgramBackendId.DACE_GPU_NO_OPT: DACE_SKIP_TEST_LIST,
ProgramBackendId.GTFN_CPU: GTFN_SKIP_TEST_LIST
+ [(USES_SCAN_NESTED, XFAIL, UNSUPPORTED_MESSAGE)],
ProgramBackendId.GTFN_CPU_IMPERATIVE: GTFN_SKIP_TEST_LIST
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,6 @@ def testee(a: cases.EField, b: cases.EField) -> cases.VField:


@pytest.mark.uses_scan
@pytest.mark.uses_scan_1d_field
def test_ternary_scan(cartesian_case):
@gtx.scan_operator(axis=KDim, forward=True, init=0.0)
def simple_scan_operator(carry: float, a: float) -> float:
Expand Down

0 comments on commit 3be5064

Please sign in to comment.