Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bump DaCe 1.0.0 -> 1.0.1 #1820

Closed
wants to merge 2 commits into from
Closed

build: Bump DaCe 1.0.0 -> 1.0.1 #1820

wants to merge 2 commits into from

Conversation

romanc
Copy link
Contributor

@romanc romanc commented Jan 23, 2025

Description

Bump DaCe to the latest stable version. This version includes a fix in DaCe's ScalarToSymbolPromotion pass.

Includes a bunch of other requirements updates (as usual). I double-checked the mypy version.

Requirements

  • All fixes and/or new features come with corresponding tests.
  • Important design decisions have been documented in the appropriate ADR inside the docs/development/ADRs/ folder.

@romanc romanc requested a review from egparedes January 23, 2025 17:01
@romanc romanc changed the title Bump DaCe 1.0.0 -> 1.0.1 build: Bump DaCe 1.0.0 -> 1.0.1 Jan 23, 2025
@romanc
Copy link
Contributor Author

romanc commented Jan 23, 2025

Blocked by #1821

romanc added 2 commits January 24, 2025 09:27
@romanc
Bump DaCe 1.0.0 -> 1.0.1
420b2ba 
This includes a backported fix for the ScalarToSymbolPromotion pass.
@romanc
running new ruff version
285febb
@romanc romanc force-pushed the romanc/update-dace branch from 0e0af6e to 285febb Compare January 24, 2025 08:27
romanc
romanc commented Jan 24, 2025
View reviewed changes
src/gt4py/next/iterator/builtins.py
@@ -6,6 +6,8 @@
# Please, refer to the LICENSE file in the root directory.
# SPDX-License-Identifier: BSD-3-Clause

# ruff: noqa: A005 Module `builtins` shadows a Python standard-library module
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this name is on purpose?

@egparedes
Copy link
Contributor

Blocked by PR #1813, which changes the development workflow to use uv for dealing with dependencies and environments. In that PR, bumping the ruff version has been explicitly avoided to keep the PR clean of unrelated format changes, but it might already include the new DaCe version if it works out of the box.

@romanc
Copy link
Contributor Author

romanc commented Jan 27, 2025

Blocked by PR #1813, which changes the development workflow to use uv for dealing with dependencies and environments. In that PR, bumping the ruff version has been explicitly avoided to keep the PR clean of unrelated format changes, but it might already include the new DaCe version if it works out of the box.

Sounds good, looking forward to uv. The dace update works out of the box. Feel free to include if you feel like it. I'll keep an eye out for PR #1813 and subsequently update/close this PR.

@egparedes
Copy link
Contributor

egparedes commented Jan 30, 2025 •
edited
Loading

#1813 has been merged and it should include the dace bump. Please, give it a try and update or remove this PR accordingly. Also note that @edopao is working on an experimental #1835 PR to add an option for using the development version of DaCe directly from the git repo, mostly for using new DaCe features in the gt4py.next subpackage.

@romanc
Copy link
Contributor Author

romanc commented Jan 30, 2025

Thanks for reporting back @egparedes. In that case, we can just close this PR.

@romanc romanc closed this Jan 30, 2025
@romanc romanc deleted the romanc/update-dace branch January 30, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egparedes egparedes Awaiting requested review from egparedes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romanc @egparedes