fix[next][dace]: Fixed a bug in the map fusion's default parameter #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`MapFusion` was behaving as the one from DaCe, i.e. it only did serial fusion by default, now it allows both by default. There are still `MapFusionSerial` and `MapFusionParallel` with the respective settings. This commit also changes auto optimizer to explicitly request them.
edopao
approved these changes
Feb 14, 2025
| @@ -81,11 +83,18 @@ class MapFusion(dace_map_fusion.MapFusion): | |||
| def __init__( | |||
| self, | |||
| strict_dataflow: bool = False, | |||
| allow_serial_map_fusion: bool = True, | |||
There was a problem hiding this comment.
It is a matter of taste, but I would make a simpler interface and not expose these 2 new parameters.
For that case teh `can_be_applied()` method never checked if the maps are parallel. The method to do that was there but not really implemented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapFusionwas behaving as the one from DaCe, i.e. it only did serial fusion by default, now it allows both by default. There are stillMapFusionSerialandMapFusionParallelwith the respective settings. This commit also changes auto optimizer to explicitly request them.