Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networking cleanup & some feature re-enable #391

Open
wants to merge 1 commit into
base: 1.10.2
Choose a base branch
from

Conversation

jjtParadox
Copy link

Alright this one's a big one. I found that a lot of packet sending and handling code hadn't been ported from 1.7.10, leaving a lot of functionality simply not working. I swept things up by commenting out stuff that wasn't being handled or used and uncommented stuff that could be handled. Here's the list of affected features:

  • Features that were commented out but are now working
    • Player velocity effects
    • Calefactor data sync
    • Magician's workbench data sync
    • Keystone combination sync and saving
    • Phylactery list creation
  • Server-to-client packets and features that are currently not being handled by client
    • Compendium Unlock
    • Hidden Component Unlock
    • Radius Spell Effect
    • Capability Change
    • Sync Extended Properties
    • One-time Affinity Activate
  • Unknown and non-operational features
    • compendiumLoad boolean in ClientTickHandler had no purpose, so it was removed.

I also removed (commented out) packet IDs that were either never used or not handled. Here's the list of unused packets:

  • SPELL_CAST
  • MAGIC_LEVEL_UP
  • PLAYER_REMOVE_ALL_BUFFS
  • ADD_BUFF_EFFECT
  • REMOVE_BUFF_EFFECT
  • CHAIN_LIGHTNING_CAST
  • SYNC_EXTENDED_PROPS
  • SYNC_SPELL_KNOWLEDGE
  • POSSIBLE_CLIENT_EXPROP_DESYNC
  • SYNC_AIR_CHANGE
  • SYNC_AFFINITY_DATA
  • NBT_DUMP
  • SPELL_APPLY_EFFECT
  • COMPENDIUM_UNLOCK
  • HIDDEN_COMPONENT_UNLOCK
  • CABABILITY_CHANGE
  • AFFINITY_ACTIVATE

Multiple of the above packets were temporarily deprecated in favor of the SYNC_CLIENT packet or networking methods provided by Forge (i.e. I found that the RUNE_BAG_GUI_OPEN packet had been superseded by Forge's FMLNetworkHandler). However, some of the above likely represent non-existent features that are missing in the current 1.10.2 version. These should be looked into and updated if possible.

Additionally, PR #364 removes the SYNC_CLIENT packet and replaces it with some of the above packets. If that PR is merged in, this PR will need to update to resolve the merge conflict.

I temporarily disabled beta tester aura sync, as the AM2 extended properties do not have data storage for the aura. That'll be in a future PR.

(Also, an "Is player flipped" packet is being sent to every player on every game player tick. Is that optimal?)

Anything commented out I couldn't find proper handling code for
@EdwinMindcraft
Copy link

Neither the flip nor the shrink feature should be enabled ideally : They're both unstable and not exactly working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants