Networking cleanup & some feature re-enable #391
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright this one's a big one. I found that a lot of packet sending and handling code hadn't been ported from 1.7.10, leaving a lot of functionality simply not working. I swept things up by commenting out stuff that wasn't being handled or used and uncommented stuff that could be handled. Here's the list of affected features:
compendiumLoad
boolean in ClientTickHandler had no purpose, so it was removed.I also removed (commented out) packet IDs that were either never used or not handled. Here's the list of unused packets:
SPELL_CAST
MAGIC_LEVEL_UP
PLAYER_REMOVE_ALL_BUFFS
ADD_BUFF_EFFECT
REMOVE_BUFF_EFFECT
CHAIN_LIGHTNING_CAST
SYNC_EXTENDED_PROPS
SYNC_SPELL_KNOWLEDGE
POSSIBLE_CLIENT_EXPROP_DESYNC
SYNC_AIR_CHANGE
SYNC_AFFINITY_DATA
NBT_DUMP
SPELL_APPLY_EFFECT
COMPENDIUM_UNLOCK
HIDDEN_COMPONENT_UNLOCK
CABABILITY_CHANGE
AFFINITY_ACTIVATE
Multiple of the above packets were temporarily deprecated in favor of the
SYNC_CLIENT
packet or networking methods provided by Forge (i.e. I found that theRUNE_BAG_GUI_OPEN
packet had been superseded by Forge's FMLNetworkHandler). However, some of the above likely represent non-existent features that are missing in the current 1.10.2 version. These should be looked into and updated if possible.Additionally, PR #364 removes the
SYNC_CLIENT
packet and replaces it with some of the above packets. If that PR is merged in, this PR will need to update to resolve the merge conflict.I temporarily disabled beta tester aura sync, as the AM2 extended properties do not have data storage for the aura. That'll be in a future PR.
(Also, an "Is player flipped" packet is being sent to every player on every game player tick. Is that optimal?)