Remove autotools build system #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byrnHDF
added
Component - Build
byrnHDF
requested review from
jhendersonHDF,
derobins,
lrknox,
fortnern,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
reviewed
Jan 17, 2025
derobins
reviewed
Jan 21, 2025
derobins
reviewed
Jan 21, 2025
.github/workflows/main-cmake.yml
Outdated
There was a problem hiding this comment.
After we do the delete, all the -cmake prefixes could be dropped from the names
derobins
reviewed
Jan 21, 2025
derobins
reviewed
Jan 21, 2025
| @@ -38,6 +38,8 @@ New features and changes | |||
| ======================== | |||
| Configuration: | |||
| ------------- | |||
| - Removed support for autotools build system. | |||
There was a problem hiding this comment.
Might also want to have another line where we mention that bin/cmakehdf4 was removed. That probably should have been done in a separate PR since it's not really an Autotools thing.
|
There's a couple of comments where we should do a final tidy before we merge the PR. Should only take a few minutes. |
|
Fixed the Makefile and gitattributes |
derobins
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.