Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove an error check regarding large cache objects #4254

Merged
merged 2 commits into from
Mar 27, 2024
Merged

Remove an error check regarding large cache objects #4254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79351e7
Remove an error check regarding large cache objects
derobins Mar 26, 2024
f59e0f3
Update RELEASE.txt
derobins Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions release_docs/RELEASE.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,17 +693,17 @@ Bug Fixes since HDF5-1.14.0 release

Library
-------
- Fixed a cache assert with too-large metadata objects
- Fixed a cache assert with very large metadata objects

If the library tries to load a metadata object that is above the
library's hard-coded limits, the size will trip an assert in debug
builds. In HDF5 1.14.4, this can happen if you create a very large
number of links in an old-style group that uses local heaps.
If the library tries to load a metadata object that is above a
certain size, this would trip an assert in debug builds. This could
happen if you create a very large number of links in an old-style
group that uses local heaps.

The library will now emit a normal error when it tries to load a
derobins marked this conversation as resolved.
Show resolved Hide resolved
metadata object that is too large.
There is no need for this assert. The library's metadata cache
can handle large objects. The assert has been removed.

Partially addresses GitHub #3762
Fixes GitHub #3762

- Fixed an issue with the Subfiling VFD and multiple opens of a
file
Expand Down
8 changes: 0 additions & 8 deletions src/H5Centry.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,14 +1288,6 @@ H5C__load_entry(H5F_t *f,

H5C__RESET_CACHE_ENTRY_STATS(entry);

/* This is a temporary fix for a problem identified in GitHub #3762, where
* it looks like a local heap entry can grow to a size that is larger
* than the metadata cache will allow. This doesn't fix the underlying
* problem, but it at least prevents the library from crashing.
*/
if (entry->size >= H5C_MAX_ENTRY_SIZE)
HGOTO_ERROR(H5E_CACHE, H5E_BADVALUE, NULL, "cache entry size is too large");

ret_value = thing;

done:
Expand Down
Loading