Related data mouseover #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ItIsJordan
commented
Nov 23, 2023
•
ItIsJordan
commented
- Adds mouseover tooltip support to the related data feature. Closes records: allow users to preview content of bidirectional links before clicking #691.
- Improve the linking for records/tables for records with multiple versions.
Adds new functions to the HEPSubmission and DataSubmission class to query for other related data object. Also adds a function to generate a dictionary generator function for combining recid/title data for the tooltip feature.
Updates the code to use the new related data functions.
Updates the related page link text to alter the record section to display record ID, with the title as a tooltip. Updates table DOI links to display the table name, with description as a tooltip.
Updates the testing for related record linking, currently working out an issue with results collection for checking.
Moves the title to the anchor tag for consistency with the other related data elements.
Fixes an error with the get_related_datasubmissions function in DataSubmission where the logic was incorrect. Also fixes the DataSubmission.get_table_data_list to use the correct relation get function.
Adds tests for the related and related_to_this functions for DataSubmission and HEPSubmission objects
Adds e2e tests to check the new tooltip update works for related data for records and tables.
Removes an unnecessary query in the get_table_data_list and get_record_data_list functions. Cleans up the variables, and removes a redundant check.
Adds comments to test functions, small cleaning changes to the new feature code.
Moves functions for related data from the models.py file and common.py into /records/api.py. Updates test_records.py to use new functions
Updates the related cleanup function to use the get_latest_hepsubmission function to ensure it always gets the most recent version, as prior versions may/will not have related data.
Updates a regular expression for checking url within a webpage to be more open in e2e/test_records.py:test_related_records
Adds a partially completed test for version tooltip testing in the e2e testing. Also adds the relevant testing data.
Adds finished test to check functionality of record page related table link tooltips.
Fiix broken path in related record test in test_records
Fixes path in test_records that breaks during full test run
Fixes docstring in newly added functions.
Updates some comments in branch changes
GraemeWatt
requested changes
Nov 24, 2023
Updates related data testing in test_records as expected rendering has changed.
Fixes directory paths in test_records.py related version testing.
Fixes comment for doi example in hepdata_tables.js
Removes unused import from api.py
Updates the related data functions in records/api.py to be request latest versions where possible
Updates pathing in related data testing
Makes the set used in get_related_to_this_hepsubmissions much simpler than before
Fixes the e2e related record test to dynamically generate the ids to ensure functionality when ran standalone and alongside the test suite
sjmf
requested changes
Nov 29, 2023
Updates commenting in test_related_records in submission_test.py to clarify a change to the dummy data
Fixes indentation for consistency in the related data functions in records/api.py.
Cleans up some lengthy import statements in submission_test.py, and records/api.py
GraemeWatt
added a commit
to HEPData/hepdata-submission
that referenced
this pull request
Dec 8, 2023
* Mention improvements introduced in HEPData/hepdata#732. * Mention that hepdata_lib can be used to write new fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.