Bidirectional preview #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a number of changes listed in #796 to forward relations ( which now appear even if relating object is not finished). As well as changes in the backwards direction, to allow tables within the same HEPSubmission to reference another in the same one.
Adds a new test to cover #796 and to potentially expand on and improve bidirectional/version relation testing.
Removed an in-comment indentation (did not think it'd break docs)
GraemeWatt
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a number of changes to functions used to query related HEPSubmission and DataSubmission objects specified in issue #796. Makes requested changes to
related_to_table_dois, andrelated_to_hepdata_records. Also adds a unit test to specifically test related table functionality outside of e2e testing.