Fix do finalise #810
Merged
Fix do finalise #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates get_commit_message in records/api.py to instances of multiple commit message returns. (now orders based on ID, and returns the first only)
Adds a test for get_commit_message to test against existence of multiple and no commit messages.
Adds validation of return message contents of get_commit_message
Improves helper function create_test_record to allow custom overall_status setting
Adds a rollback condition when exception raised in do_finalise, now returns error in some exceptions during record commit. Also adds some testing for rollback condition.
Fix path in test_do_finalise_commit_message to use absolute path, which I hope works on the actions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #761 by making a number of improvements: