Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analyses test #849

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Add analyses test #849

merged 6 commits into from
Dec 10, 2024

Conversation

ItIsJordan
Copy link
Collaborator

@ItIsJordan ItIsJordan commented Dec 9, 2024

Adds a specific test function to the for the add_analyses function in the OpenSearch API, verifying addition of resources to the OpenSearch index object. This should increase coverage and include missing lines.

Closes #809.

Adds a basic test for the add_analyses functionality, and a test data folder.
Adds NUISANCE to test_add_analyses and fix files used for other file types.
Add specific check for MadAnalysis resource after submission.yml resources are checked in search_test.py
Fixes a bug where testing for MadAnalysis was checking against the database entry and not the document dictionary (as it should have been)
@coveralls
Copy link

Coverage Status

coverage: 83.647% (+0.02%) from 83.629%
when pulling 145013b on add-analyses-test
into d1ba472 on main.

Copy link
Member

@GraemeWatt GraemeWatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Merging now.

@GraemeWatt GraemeWatt merged commit 2405420 into main Dec 10, 2024
7 checks passed
@GraemeWatt GraemeWatt deleted the add-analyses-test branch December 10, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tests: add test for add_analyses function
3 participants