Enable HMCL to export jstack dump file 让 HMCL 能够导出游戏运行栈文件 #2582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umpHeadTo from public to private
| } else { | ||
| exportDumpButton.setText(i18n("logwindow.export_dump.no_dependency.button")); | ||
| exportDumpButton.setTooltip(new Tooltip(i18n("logwindow.export_dump.no_dependency.tooltip"))); | ||
| exportDumpButton.setButtonType(JFXButton.ButtonType.RAISED); |
There was a problem hiding this comment.
为什么不支持的时候反而是 RAISED 的？
There was a problem hiding this comment.
抱歉，想写 setDisabled 的，写错了
| @@ -20,6 +20,7 @@ subprojects { | |||
| } | |||
| mavenCentral() | |||
| maven(url = "https://jitpack.io") | |||
| maven(url = "https://libraries.minecraft.net") | |||
There was a problem hiding this comment.
什么库需要libraries.minecraft.net?
|
不明觉厉 |
|
…… |
|
是 BCIG 库（依赖 Mojang Brigadier）…… 最开始引入于 SimpleWEBP，用于支持不同 JavaFX 版本（后来就拉进来了） |
|
这个库不是已经替换成你自己的名字了么，还需要libraries.minecraft.net? |
|
但 Mojang Brigadier 需要从 libraries.minecraft.net 下载 |
|
修复了一个 Bug，并移除了通过正则隐藏 access token 的方法。转而使用 Logging 中现成的轮子 |
half-nothing
pushed a commit
to half-nothing/HMCL-liteUI
that referenced
this pull request
Jan 11, 2024
) * Enable HMCL to create game thread dump while game is running * Fix checkstyle * Hide accessToken * Code cleanup * Code cleanup * Enhance I18N and declare the charset (UTF-8) of output file * Inline variables * Update the modifier of org.jackhuang.hmcl.game.GameDumpCreator#writeDumpHeadTo from public to private * Refactor * Add license for GameDumpCreator, remove support for Java 8 * Remove unnecessary Arrays.copyOf * Fix checkstyle * Use system charset to read the inputstream from JVM * opt GameDumpCreator * retry on failed attach to vm * update GameDumpCreator * Opt GameDumpCreator * Fix * Include BCIG * Use BCIG to get PID. * Fix. * Fix again. * Code cleanup. Fix bugs. --------- Co-authored-by: Glavo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
接 #2200