Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor constants to interface in menu factories #7023

Merged
merged 23 commits into from
Jan 16, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
f96fb5b
Refactor constants to interface in menu factories
pethers Jan 14, 2025
2c008f9
Move constants to `MenuItemConstants` interface and update references
pethers Jan 14, 2025
5d42778
Remove constants from `CommitteeMenuItemFactoryImpl` and `GovernmentB…
pethers Jan 14, 2025
64f5289
Update `UserHomeMenuItemFactoryImpl`, `CommitteeMenuItemFactoryImpl`,…
pethers Jan 14, 2025
d635a7c
Add new constants to `MenuItemConstants` interface
pethers Jan 14, 2025
f9c9b60
Add missing symbols 'LIST' and 'SEARCH' to the `PageMode` enum
pethers Jan 14, 2025
f76971e
Add constants for menu items in `MenuItemConstants` and refactor clas…
pethers Jan 14, 2025
e2b1126
Implement `MenuItemConstants` interface in `ParliamentMenuItemFactory…
pethers Jan 14, 2025
db4ba6d
Implement `MenuItemConstants` interface in `PartyMenuItemFactoryImpl`…
pethers Jan 14, 2025
7081038
Implement `MenuItemConstants` interface in `PartyRankingMenuItemFacto…
pethers Jan 14, 2025
7afb381
Update `UserHomeMenuItemFactoryImpl` to use constants from `MenuItemC…
pethers Jan 14, 2025
bd03208
Add `MenuItemConstants` interface to hold all constants
pethers Jan 15, 2025
6eda8f3
Add missing constants to `MenuItemConstants` interface
pethers Jan 15, 2025
049198b
Add missing constants to `MenuItemConstants` interface
pethers Jan 15, 2025
a595a64
Refactor `MenuItemConstants` interface to improve organization and ma…
pethers Jan 15, 2025
0b92bf2
Update `AbstractMenuItemFactoryImpl` to implement `MenuItemPageModeMe…
pethers Jan 15, 2025
266e746
Update `AbstractMenuItemFactoryImpl` to implement `PageModeMenuComman…
pethers Jan 15, 2025
becf8f9
Update dependencies and clean up POM files for improved organization
pethers Jan 15, 2025
369b824
Update module-info.java to require transitive dependencies for improv…
pethers Jan 15, 2025
b170659
Add PageModeMenuCommandAdminConstants interface for admin view commands
pethers Jan 15, 2025
7e61e20
Add menu item constants for layout, navigation, party, document, user…
pethers Jan 15, 2025
8a98f7f
Add new menu item constants for data, layout, risk, leadership, count…
pethers Jan 16, 2025
4215762
Merge branch 'master' into pethers/refactor-constants
pethers Jan 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions citizen-intelligence-agency/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
<exec executable="${maven.binary}" dir="../parent-pom/">
<env key="MAVEN_OPTS" value="-server -Xmx2048m -Xms2048m " />
<arg
line="-B --file pom.xml clean install -Prelease-site,all-modules -DforkMode=once '-Dtest=!**ITest*,!**DocumentationTest*' -Dmaven.test.failure.ignore=true -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dsurefire.reportNameSuffix=UNIT" />
line="-B --file pom.xml clean install -pl !cia-dist-deb -Prelease-site,all-modules -DforkMode=once '-Dtest=!**ITest*,!**DocumentationTest*' -Dmaven.test.failure.ignore=true -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Dsurefire.reportNameSuffix=UNIT" />
</exec>
</target>

Expand All @@ -48,7 +48,7 @@
<exec executable="${maven.binary}" dir="../parent-pom/">
<env key="MAVEN_OPTS" value="-server -Xmx2048m -Xms2048m " />
<arg
line="clean install -T 1.5C -Pall-modules -Dhttps.protocols=TLSv1.2 -Dmaven.test.failure.ignore=true" />
line="clean install -T 1.5C -pl !cia-dist-deb -Pall-modules -Dhttps.protocols=TLSv1.2 -Dmaven.test.failure.ignore=true" />
</exec>
</target>
<target name="clean-install-service" description="cia-clean-install-service" depends="init">
Expand All @@ -64,10 +64,10 @@
</exec>
</target>
<target name="clean-install-notest" description="cia-clean-install-notest" depends="init">
<exec executable="${maven.binary}" dir="../parent-pom/">
<exec executable="${maven.binary}" dir="../">
<env key="MAVEN_OPTS" value="-server -Xmx2048m -Xms2048m " />
<arg
line="clean install -Dtest=no -DfailIfNoTests=false -Dsurefire.failIfNoSpecifiedTests=false -Pall-modules -Dhttps.protocols=TLSv1.2" />
line="clean install -Dtest=no -DfailIfNoTests=false -Pall-modules -Dsurefire.failIfNoSpecifiedTests=false -pl '!cia-dist-deb,!cia-dist-cloudformation'" />
</exec>
</target>

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
package com.hack23.cia.web.impl.ui.application.views.common.menufactory.api;

public interface MenuItemAdminConstants {
String ADMIN_TEXT = "Admin";
String AGENCY = "Agency";
String AGENT_OPERATIONS_TEXT = "Agent operations";
String APPLICATION = "Application";
String APPLICATION_CONFIGURATION = "System settings";
String APPLICATION_EVENT = "Application Event";
String APPLICATION_EVENT_CHARTS = "Application Event charts";
String APPLICATION_SESSION = "Application Session";
String APPLICATION_SESSION_CHARTS = "Active Daily Users";
String SYSTEM_PERFORMANCE = "System Performance";
String MANAGEMENT = "Management";
String CONFIGURATION = "Configuration";
String PORTAL = "Portal";
String EMAIL = "Email";
String LANGUAGE = "Language";


/** The Constant DATA_AUTHOR_SUMMARY. */
String DATA_AUTHOR_SUMMARY = "Data author summary";

/** The Constant DATA_SUMMARY_TEXT. */
String DATA_SUMMARY_TEXT = "Data Summary";



}
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package com.hack23.cia.web.impl.ui.application.views.common.menufactory.api;

/**
* Constants for committee-related menu items.
*/
public interface MenuItemCommitteeConstants {
// Base committee labels
String COMMITTEE_RANKING_TEXT = "Committee Ranking";
String COMMITTEE_ROLES = "Committee Roles";
String COMMITTEES_LINK_TEXT = "Committees";

// Committee descriptions
String COMMITTEE_RANKING_DESCRIPTION = "Committees: shaping policy debates.";
String COMMITTEES_DESCRIPTION = "All committees: roles and responsibilities.";
String COMMITTEE_ROLES_DESCRIPTION = "Committee roles description";
String PAGE_VISIT_HISTORY_DESCRIPTION = "View history of page visit for this page.";

// Document and ballot related
String DOCUMENTS_TEXT = "Documents";
String BALLOTS_TEXT = "Ballots";
String BALLOT_DECISION_SUMMARY_TEXT = "Ballot Decision Summary";

// Other committee constants
String CURRENT_COMMITTEES_TEXT = "Current Committees";
String COMMITTEE_HISTORY_TEXT = "Committee History";
String COMMITTEE_DETAILS_TEXT = "Committee Details";
}
Loading
Loading