Fixing build issue with Linux/Clang/C++23 #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io_base doesn't have a declared destructor, and gets an automatically generated one. This automatic destructor tries to destruct the pimpl unique pointer and causes a compilation failure. Fix: add an explicit destructor with an empty implementation in the cpp file.
|
Hi! Thanks for the PR! An interesting question is, does this change break ABI? I guess no. |
|
I don't think this changes it. The destructor was already part of io_base.cpp (and any other TU that included io_base.h), and because of that, it was included in the binding library. After this change, it will be still part of the library. The only difference is that now code using io_base.h won't try to generate a default implementation of the destructor. I also verified this with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_base doesn't have a declared destructor, and gets an automatically generated one. This automatic destructor tries to destruct the pimpl unique pointer and causes a compilation failure.
Fix: add an explicit destructor with an empty implementation in the cpp file.