Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/reference ray visualization #44

Merged
merged 7 commits into from
Jan 28, 2025

Conversation

HarrisonKramer
Copy link
Owner

  • Add ability to plot reference rays (chief or marginal) alongside, or separate from, standard ray bundles for 2D/3D visualization

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
unittests 97.37% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
optiland/optic.py 98.97% <100.00%> (+2.05%) ⬆️
optiland/visualization/rays.py 100.00% <100.00%> (ø)
optiland/visualization/visualization.py 95.65% <ø> (ø)

@HarrisonKramer HarrisonKramer merged commit b3d637b into master Jan 28, 2025
5 checks passed
@HarrisonKramer HarrisonKramer deleted the feat/reference_ray_visualization branch January 28, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Plotting Functionality for Reference Rays (Marginal and Chief Rays)
1 participant