Skip to content

Commit

Permalink
Leave docker buildx --load to GitHub Action code, as it slows down lo…
Browse files Browse the repository at this point in the history
…cal builds and isn't necessary there.
  • Loading branch information
alexdlaird committed Oct 17, 2024
1 parent 0d244f2 commit 7c7a57a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 4 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,10 @@ jobs:
run: make test
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
- name: Test Docker build
run: make build-docker
run: |
make build-docker
docker buildx build -t helium/frontend:latest --load .
make run-docker
- name: Upload coverage
uses: codecov/codecov-action@v3
with:
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ test:

build-docker:
docker buildx build -t helium/frontend:latest -t helium/frontend:$(TAG_VERSION) --platform=$(PLATFORM) .
docker buildx build -t helium/frontend:latest --load .

run-docker:
docker compose up -d
Expand Down

0 comments on commit 7c7a57a

Please sign in to comment.