Migrate to HerbSpecification.jl
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hijacking the PR to update to |
ReubenJ
force-pushed
the
migrate-to-herbspec
branch
from
95751a5 to
6f63c45
Compare
ReubenJ
force-pushed
the
migrate-to-herbspec
branch
from
6f63c45 to
d90a88b
Compare
|
Sorry, ironically made a mess of this PR by rebasing/cleaning up commits. It's now rebased on dev to reflect the changes from #15. Should be ready for review/merge @THinnerichs |
|
I will re-add the formatting we had, i.e. new line for each IOExample. |
THinnerichs
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HerbData.jlhas been deprecated in favor ofHerbSpecification.jl. I've updated the benchmarks to use the newProblemtype that includes a problem name field and arrays ofIOExamples instead ofExamples for the problem specification.Closes #9 and #16.
The package will not precompile, and tests won't pass until Herb-AI/HerbGrammar.jl#54 is merged (and released, I guess?), thus, the draft PR.
The refactor I needed to do involved more than renaming symbols (I had to copy the variable name for each problem to the name field of the constructor), so I scripted it. In case anyone wants to take a peak, the script is in a branch here.