Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isvariable #45

Merged
merged 4 commits into from
Jan 19, 2024
Merged

Fix isvariable #45

merged 4 commits into from
Jan 19, 2024

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Jan 18, 2024

  • Generalize utility function for checking symbols
  • Allow for module specification in isvariable(...)
  • Add tests for isvariable with specified module(s)

This refactor allows for the reuse of the logic that checks
whether a symbol is defined in a specific `Module` or `Main`/`Base`.
Allow the specification one or more `Module` when checking if a
rule used by a `RuleNode` represents a variable, or if it is
defined in one of the specified `Module`s, `Main`, or `Base`.

Fixes #21.
@ReubenJ ReubenJ added the enhancement New feature or request label Jan 18, 2024
@ReubenJ ReubenJ self-assigned this Jan 18, 2024
@ReubenJ ReubenJ requested a review from THinnerichs January 18, 2024 13:59
@ReubenJ ReubenJ changed the title Fix \isvariable\ Fix isvariable Jan 18, 2024
@IssaHanou IssaHanou merged commit 370cc13 into dev Jan 19, 2024
2 checks passed
@IssaHanou IssaHanou deleted the fix-isvariable branch January 19, 2024 09:29
@IssaHanou IssaHanou mentioned this pull request Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants