Merge grammar updates to Master for publication #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function to merge grammars
This refactor allows for the reuse of the logic that checks whether a symbol is defined in a specific `Module` or `Main`/`Base`.
Allow the specification one or more `Module` when checking if a rule used by a `RuleNode` represents a variable, or if it is defined in one of the specified `Module`s, `Main`, or `Base`. Fixes #21.
If the expression passed for a rule is malformed, the function now throws an `ArgumentException` Fixes #37.
Make `add_rule!(...)` fail audibly
Fix `isvariable`
Currently, the rule `true` is equivalent to the rule `1`. This means that if one of them already exists in the grammar, the new one is skipped.
`add_rule!(...)` type coercion bug
sebdumancic
approved these changes
Feb 7, 2024
ReubenJ
reviewed
Feb 12, 2024
There was a problem hiding this comment.
Looks good to me. Just one aesthetic/design comment: I remember reading in an old issue or PR that part of the CFG -> CSG migration would include renaming ContextSensitiveGrammar to Grammar. Did we discuss that option and decide against it? I can see arguments for both keeping the names as they are now, or moving completely to Grammar.
Without them, an empty grammar results in many `Vector{Any}`s, closes #53
Fix empty grammar creation
Grammar -> AbstractGrammar according to HerbCore 0.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (as far as I remember):
cfgs withcsgs entirely (both macros still work)add_rule!failing silentlyisvariablefix