Update versions for DataStructures to ensure compat with SExpressions
#57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReubenJ
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Still hesitant that we should lock in on a specific version of DataStructures just because SExpressions requires the older version—DataStructures==0.17 is almost 4 years old. I verified that all of SExpression's tests pass with DataStructures==0.18.17, so I might be in favor of forking it. Thoughts?
|
There's already an open PR (TotalVerb/SExpressions.jl#12). If that's merged quickly, then this can be ignored, otherwise we can just restrict the versions for now. |
ReubenJ
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SExpressions, extensively used inHerbBenchmarks/SyGuS, has dependencyDataStructures= "0.14,0.17"resolving to[0.14,0.19).Changed the
DataStructurescompat inHerbGrammarto^0.18, which passed all checks, but leads to this not being compatible anymore.