Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insert!ion of AbstractRuleNodes #76

Closed
wants to merge 1 commit into from

Conversation

ReubenJ
Copy link
Member

@ReubenJ ReubenJ commented Jun 3, 2024

Currently, restricting to concrete RuleNodes restricts the user from inserting a Hole, for example.

Copy link

codecov bot commented Jun 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 46.10%. Comparing base (aca61f9) to head (0f92127).

Files Patch % Lines
src/nodelocation.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files           8        8           
  Lines         462      462           
=======================================
  Hits          213      213           
  Misses        249      249           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@THinnerichs
Copy link
Member

As @nicolaefilat said: Your change is valid.
However, with the current implementation you cannot substitute the entire tree with a hole, if I am not mistaken.
This would be possible when constricting to RuleNodes specifically.

@ReubenJ
Copy link
Member Author

ReubenJ commented Jun 3, 2024

This is missing a test, which, if we had it, would show that Holes do not have an ind field. Add a new method for Holes instead.

@ReubenJ
Copy link
Member Author

ReubenJ commented Jun 3, 2024

Closing in favor of releasing on v0.2.x branch

@ReubenJ ReubenJ closed this Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants