Expr2 rule node #98
Merged
Expr2 rule node #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
==========================================
+ Coverage 45.83% 52.60% +6.76%
==========================================
Files 7 7
Lines 456 557 +101
==========================================
+ Hits 209 293 +84
- Misses 247 264 +17 ☔ View full report in Codecov by Sentry. |
ReubenJ
requested changes
Nov 26, 2024
src/rulenode_operators.jl
Outdated
Comment on lines
214
to
218
| """ | ||
| expr2ulenode(expr::Expr, grammar::AbstractGrammar) | ||
|
|
||
| Converts an expression into a [`AbstractRuleNode`](@ref) corresponding to the rule definitions in the grammar. | ||
| """ |
There was a problem hiding this comment.
This needs to be directly before the definition of expr2rulenode(...). The signature in the docstring is missing an 'r', btw.
ReubenJ
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.