Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty stdout #48

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix empty stdout #48

wants to merge 1 commit into from

Conversation

cabloo
Copy link

@cabloo cabloo commented Jul 14, 2015

No description provided.

@dmouse
Copy link

dmouse commented Sep 6, 2015

👍

@cabloo
Copy link
Author

cabloo commented Sep 6, 2015

Would be nice to have this merged, the issue caused significant debugging pains for me a while back. I'm sure others have come across the same problem.

@h4cc
Copy link
Collaborator

h4cc commented Sep 21, 2015

The fix assumes, that if a command was executed and the echo part was not run, that result of the execution should be a error with a exit code != 0?

@Herzult Sounds right to me.

@cabloo
Copy link
Author

cabloo commented Mar 29, 2016

Bump. I just ran into this issue again when using this library in another project. I don't know what it is about these use cases but this has happened to me more than once now! And this is a pretty straightforward fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants