-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pass in host pubkey to ensure correct in dev env #10
Conversation
@@ -16,19 +16,10 @@ use types::{HappAndHost, HappDetails, ZomeCallRequest, ZomeCallResponse}; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to verify - Is the security for this api is the same as was for the hpos v1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This API does not require authentication, because nginx in front of this API performs authentication. Same as for v1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you. That's exactly what I wanted to confirm.
#[post("/hosted_happs/<happ_id>/<hp_id>/enable")] | ||
async fn enable_happ( | ||
happ_id: &str, | ||
hp_id: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is better to read the hp_id from the config file instead of expecting it to be passed from the UI.
That is how the old endpoint worked as well
This can open enabling apps endpoint to other issues
@JettTech can you elaborate a bit more on a need for this code change? |
I have changed a base branch to |
@peeech - yes, the reason this needs to be changed is because in develop, the host keys are not the same as the holoport id, therefore without a change, all hosting infra testing in devnet will be unsuccessful as the happs will be not be enabled for the host's holoport id and therefore never be routed to available hosts. |
This PR is superseded by #11. |
Context: We need to pass in the host pubkey from host console to ensure that we're referencing the correct pubkey in all envs - including dev.
Updates:
/
call to act as server ping