Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass in host pubkey to ensure correct in dev env #10

Closed
wants to merge 1 commit into from

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Jan 24, 2024

Context: We need to pass in the host pubkey from host console to ensure that we're referencing the correct pubkey in all envs - including dev.

Updates:

  • adds host pubkey param to enable happ and disable happ calls
  • updates / call to act as server ping

@JettTech JettTech requested review from peeech and zo-el January 24, 2024 15:44
@@ -16,19 +16,10 @@ use types::{HappAndHost, HappDetails, ZomeCallRequest, ZomeCallResponse};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to verify - Is the security for this api is the same as was for the hpos v1?

Copy link
Contributor

@peeech peeech Jan 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API does not require authentication, because nginx in front of this API performs authentication. Same as for v1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you. That's exactly what I wanted to confirm.

#[post("/hosted_happs/<happ_id>/<hp_id>/enable")]
async fn enable_happ(
happ_id: &str,
hp_id: String,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is better to read the hp_id from the config file instead of expecting it to be passed from the UI.
That is how the old endpoint worked as well
This can open enabling apps endpoint to other issues

@peeech
Copy link
Contributor

peeech commented Jan 24, 2024

@JettTech can you elaborate a bit more on a need for this code change?

@peeech peeech changed the base branch from main to develop January 25, 2024 08:44
@peeech
Copy link
Contributor

peeech commented Jan 25, 2024

I have changed a base branch to develop because this is the branch that offers automated tests in this repo.

@JettTech
Copy link
Contributor Author

JettTech commented Jan 25, 2024

@peeech - yes, the reason this needs to be changed is because in develop, the host keys are not the same as the holoport id, therefore without a change, all hosting infra testing in devnet will be unsuccessful as the happs will be not be enabled for the host's holoport id and therefore never be routed to available hosts.

@JettTech
Copy link
Contributor Author

This PR is superseded by #11.

@JettTech JettTech closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants