-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update transaction status::accepted #46
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we update this common crate here.
So that we have the types in one place
So why do these types exist in the hpos-api code if they're imported from the common crate? |
Those are holofuel - specific types I think and because holofuel does not expose public crate with those types we are just manually defining them in the code of both |
I agree with this in general, but its a lot of work to extract it from the transactor_integrity zome. (I wish it was easier, zippy has tried it too) Thats why we created it in here was may attempt to extract it fro the transactor_integrity zome, but its not completed |
Ok I'm just going to update hops-connect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
accepting to speed up the bug fix
Updates API for new transactionStatus struct