Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorbet/config: handle some homebrew-bundle cases. #19055

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

MikeMcQuaid
Copy link
Member

  • need to ignore vendor/ruby because there can be gems in there
  • need to ignore spec/stub because it's defining RSpec-only stub methods that aren't used outside of RSpec and don't have the same e.g. signatures.

- need to ignore `vendor/ruby` because there can be gems in there
- need to ignore `spec/stub` because it's defining RSpec-only stub
  methods that aren't used outside of RSpec and don't have the same
  e.g. signatures.
Copy link
Member

@issyl0 issyl0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this makes sense for the errors I remember seeing in bundle!

@MikeMcQuaid MikeMcQuaid enabled auto-merge January 8, 2025 16:05
@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Jan 8, 2025
Merged via the queue into master with commit 7e1d14e Jan 8, 2025
29 checks passed
@MikeMcQuaid MikeMcQuaid deleted the brew_bundle_typecheck branch January 8, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants