Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump some utils/ files to Sorbet typed: strict #19094

Merged
merged 6 commits into from
Jan 22, 2025
Merged

Conversation

issyl0
Copy link
Member

@issyl0 issyl0 commented Jan 14, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@issyl0 issyl0 marked this pull request as ready for review January 14, 2025 23:45
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go whenever you are! All comments are non-blocking, we can always clean this up post merge.

Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/analytics.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/shell.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/spdx.rb Show resolved Hide resolved
Library/Homebrew/utils/tty.rb Outdated Show resolved Hide resolved
@issyl0 issyl0 force-pushed the utils-sorbet-strict branch 2 times, most recently from 6b544d8 to d2fd233 Compare January 22, 2025 12:02
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! All comments are non-blocking, feel free to disagree and self-merge with or without accepting without a rereview.

Library/Homebrew/utils/pypi.rb Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/pypi.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/shell.rb Outdated Show resolved Hide resolved
Library/Homebrew/utils/tty.rb Outdated Show resolved Hide resolved
@issyl0 issyl0 force-pushed the utils-sorbet-strict branch from d2fd233 to 66e5084 Compare January 22, 2025 22:12
@issyl0 issyl0 enabled auto-merge January 22, 2025 22:27
@issyl0 issyl0 added this pull request to the merge queue Jan 22, 2025
Merged via the queue into master with commit fa40d2f Jan 22, 2025
31 checks passed
@issyl0 issyl0 deleted the utils-sorbet-strict branch January 22, 2025 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants