Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nanum square font family casks #197441

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

wodory
Copy link

@wodory wodory commented Jan 7, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@BrewTestBot BrewTestBot added automerge-skip new cask missing zap Cask is missing a zap stanza, please add one. labels Jan 7, 2025
@wodory wodory closed this Jan 7, 2025
@wodory wodory reopened this Jan 8, 2025
@BrewTestBot BrewTestBot removed the missing zap Cask is missing a zap stanza, please add one. label Jan 8, 2025
@khipp khipp force-pushed the add-nanum-square-font-family-casks branch from 5a7a183 to 2112440 Compare January 8, 2025 08:16
@khipp
Copy link
Member

khipp commented Jan 8, 2025

The installation seems to only fail on the Intel-based runner. Maybe it has something to do with the archive?

@bevanjkay
Copy link
Member

@wodory I pushed an update to use the otf variants, as we usually prefer these over ttf, unless there is a compelling reason to stay with the ttf options?

@wodory
Copy link
Author

wodory commented Jan 8, 2025

@wodory I pushed an update to use the otf variants, as we usually prefer these over ttf, unless there is a compelling reason to stay with the ttf options?

OTF fonts, especially in MS Office, may cause some minor problems with the spacing of Korean characters. That's why I chose TTF.

@bevanjkay bevanjkay force-pushed the add-nanum-square-font-family-casks branch from 5258087 to d99a604 Compare January 8, 2025 09:53
@khipp
Copy link
Member

khipp commented Jan 8, 2025

Thank you for your first contribution to homebrew-cask, @wodory! 🎉

@khipp khipp merged commit 4ac1359 into Homebrew:master Jan 8, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants