Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mysql-shell: add user_agent #200191

Merged
merged 2 commits into from
Jan 31, 2025
Merged

mysql-shell: add user_agent #200191

merged 2 commits into from
Jan 31, 2025

Conversation

samford
Copy link
Member

@samford samford commented Jan 31, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

The asset URL for mysql-shell is correct but the download appears to fail with the default user agent as well as user_agent: :fake (or :browser). It does appear to work with user_agent: "curl/8.7.1", as used in a few other casks.

Fixes #200164.

The asset URL for `mysql-shell` is correct but the download appears to
fail with the default user agent as well as `user_agent: :fake` (or
`:browser`). It does appear to work with `user_agent: "curl/8.7.1"`,
as used in a few other casks.
@samford
Copy link
Member Author

samford commented Jan 31, 2025

Oh joy, the livecheck block URL is broken on CI for the same reason 😭

[For context, livecheck doesn't support manually setting the user agent yet. I have the feature implemented but I'm working through some related Utils::Curl changes first.]

If the livecheck block works locally for others, we can just skip livecheck on CI for now.

@khipp
Copy link
Member

khipp commented Jan 31, 2025

Would whitelisting the URLs in the secure_connection_audit_skiplist.json help? We did this with the tableau casks, which also had 403 errors.

@samford
Copy link
Member Author

samford commented Jan 31, 2025

Would whitelisting the URLs in the secure_connection_audit_skiplist.json help?

I gave it a shot but this situation appears to be different.

Edit: Oh wait, looks like it works if we add both the homepage and livecheck URL (and it helps if I type the JSON without syntax errors 😆).

@samford samford force-pushed the mysql-shell-add-user-agent branch 2 times, most recently from a9a7e67 to 4658ac6 Compare January 31, 2025 17:00
@samford samford force-pushed the mysql-shell-add-user-agent branch from 4658ac6 to ba01403 Compare January 31, 2025 17:01
Copy link
Member

@khipp khipp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad I could help!

@khipp khipp merged commit 5e78f4e into master Jan 31, 2025
15 checks passed
@khipp khipp deleted the mysql-shell-add-user-agent branch January 31, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mysql-shell cask needs to be updated for macos Sequoia
3 participants