Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consul: migrate formula to casks #200992

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

botantony
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

this formula was deprecated almost one year ago and yet it is still being used (see analytics) and some formulae use it as a dependency. i think it would be better to at least migrate this formula to casks rather than removing it from the official repo completely

p.s. for some reasons brew audit --cask --new consul prints consul is listed in tap_migrations.json despite being removed from the list

@botantony
Copy link
Author

ok, now i get it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants