-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corkscrew: replace WEBrick with TCPServer for test, update license #162843
corkscrew: replace WEBrick with TCPServer for test, update license #162843
Conversation
Please provide a better issue/pull request title and/or description! |
c8b5360
to
cc27d67
Compare
@@ -3,7 +3,7 @@ class Corkscrew < Formula | |||
homepage "https://packages.debian.org/sid/corkscrew" | |||
url "https://deb.debian.org/debian/pool/main/c/corkscrew/corkscrew_2.0.orig.tar.gz" | |||
sha256 "0d0fcbb41cba4a81c4ab494459472086f377f9edb78a2e2238ed19b58956b0be" | |||
license "GPL-2.0" | |||
license "GPL-2.0-or-later" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relates to #162041 (comment) |
- replace WEBrick with TCPServer for test - update license to GPL-2.0-or-later
cc27d67
to
c321387
Compare
@timsutton I'm not sure we should be only running syntax here to make sure the tests pass on CI. But can add |
@bevanjkay Ah, thank you for pointing that out! I didn't realize the label would cause it to skip tests, but I guess that makes sense. I'll remove the label then. |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?