Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corkscrew: replace WEBrick with TCPServer for test, update license #162843

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

timsutton
Copy link
Member

@timsutton timsutton commented Feb 15, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • replace WEBrick with TCPServer (as suggested here)
  • update license to GPL 2.0 to GPL-2.0-or-later

@github-actions github-actions bot added the deprecated license Formula uses a deprecated SPDX license which should be updated label Feb 15, 2024
Copy link

request-info bot commented Feb 15, 2024

Please provide a better issue/pull request title and/or description!

@request-info request-info bot added the needs response Needs a response from the issue/PR author label Feb 15, 2024
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed deprecated license Formula uses a deprecated SPDX license which should be updated labels Feb 15, 2024
@timsutton timsutton force-pushed the corkscrew-tcpserver-for-test branch from c8b5360 to cc27d67 Compare February 15, 2024 17:18
@timsutton timsutton changed the title corkscrew: replace WEBrick with TCPServer for test corkscrew: replace WEBrick with TCPServer for test, update license Feb 15, 2024
@@ -3,7 +3,7 @@ class Corkscrew < Formula
homepage "https://packages.debian.org/sid/corkscrew"
url "https://deb.debian.org/debian/pool/main/c/corkscrew/corkscrew_2.0.orig.tar.gz"
sha256 "0d0fcbb41cba4a81c4ab494459472086f377f9edb78a2e2238ed19b58956b0be"
license "GPL-2.0"
license "GPL-2.0-or-later"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timsutton
Copy link
Member Author

Relates to #162041 (comment)

@timsutton timsutton added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Feb 15, 2024
- replace WEBrick with TCPServer for test
- update license to GPL-2.0-or-later
@timsutton timsutton force-pushed the corkscrew-tcpserver-for-test branch from cc27d67 to c321387 Compare February 15, 2024 17:33
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Feb 15, 2024
@timsutton timsutton marked this pull request as ready for review February 15, 2024 17:34
@bevanjkay
Copy link
Member

@timsutton I'm not sure we should be only running syntax here to make sure the tests pass on CI. But can add ci-no-bottles.

@timsutton
Copy link
Member Author

@bevanjkay Ah, thank you for pointing that out! I didn't realize the label would cause it to skip tests, but I guess that makes sense. I'll remove the label then.

@p-linnane p-linnane removed the needs response Needs a response from the issue/PR author label Feb 15, 2024
@timsutton timsutton added needs response Needs a response from the issue/PR author CI-no-bottles Merge without publishing bottles and removed CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. labels Feb 15, 2024
@p-linnane p-linnane removed the needs response Needs a response from the issue/PR author label Feb 15, 2024
@bevanjkay bevanjkay added needs response Needs a response from the issue/PR author license License PRs labels Feb 15, 2024
@p-linnane p-linnane removed the needs response Needs a response from the issue/PR author label Feb 15, 2024
@p-linnane p-linnane enabled auto-merge February 15, 2024 17:45
@p-linnane p-linnane added this pull request to the merge queue Feb 15, 2024
Merged via the queue into Homebrew:master with commit 965a63b Feb 15, 2024
30 checks passed
@timsutton timsutton deleted the corkscrew-tcpserver-for-test branch February 15, 2024 18:03
@github-actions github-actions bot added the outdated PR was locked due to age label Mar 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-bottles Merge without publishing bottles license License PRs outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants