Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

duff: update home url #168976

Merged
merged 1 commit into from
Apr 14, 2024
Merged

duff: update home url #168976

merged 1 commit into from
Apr 14, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Apr 14, 2024

The current url redirects to a domain name that is not under upstream's control anymore. See elmindreda/duff#14
and
elmindreda/duff@c1baefa

We could also use https://sourceforge.net/projects/duff as home url, but given elmindreda/duff#14 (comment), there is no link from sourceforge to the github project, so using the github link seems to be a better move for now.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The current url redirects to a domain name that is not under upstream's control anymore.
See elmindreda/duff#14
and
elmindreda/duff@c1baefa

We could also use https://sourceforge.net/projects/duff as home url,
but given elmindreda/duff#14 (comment),
there is no link from sourceforge to the github project, so using the github
link seems to be a better move for now.
@iMichka iMichka added the CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. label Apr 14, 2024
@github-actions github-actions bot added the missing license Formula has a missing license which should be added label Apr 14, 2024
@iMichka
Copy link
Member Author

iMichka commented Apr 14, 2024

For any maintainer approving this: please carefully cross-check the change (in case something fishy is going on, I don't want to have another xz drama on our hands).

Copy link
Member

@ZhongRuoyu ZhongRuoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked.

@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 14, 2024
Merged via the queue into Homebrew:master with commit 38727be Apr 14, 2024
16 checks passed
@iMichka iMichka deleted the duff branch April 14, 2024 18:51
@github-actions github-actions bot added the outdated PR was locked due to age label May 15, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-syntax-only Change only affects brew syntax, not the install. Only run syntax CI. missing license Formula has a missing license which should be added outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants