Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acme.sh 3.1.0 (new formula) #205068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

acme.sh 3.1.0 (new formula) #205068

wants to merge 1 commit into from

Conversation

kidonng
Copy link
Contributor

@kidonng kidonng commented Jan 21, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jan 21, 2025
@chenrui333
Copy link
Member

osx tests need to be updated

  An exception occurred within a child process:
    Minitest::Assertion: Expected /Main_Domain\tKeyLength\tSAN_Domains\tCA\tCreated\tRenew\n/ to match "Main_Domain  KeyLength  SAN_Domains  CA  Created  Renew\n".

@kidonng
Copy link
Contributor Author

kidonng commented Jan 22, 2025

Oh weird 😅 seems like the output differs a bit depending on the shell?

https://github.com/acmesh-official/acme.sh/blob/f981c782bb38015f4778913e9c3db26b57dde4e8/acme.sh#L5755-L5795

Will look into other subcommands for the test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants