Fix unsigned, write longs as strings #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie400
reviewed
Jul 12, 2023
src/main/java/com/hubspot/jackson/datatype/protobuf/ProtobufDeserializer.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hubspot/jackson/datatype/protobuf/builtin/serializers/DurationSerializer.java
Show resolved
Hide resolved
|
I'm planning to do a follow-up PR to add an option for serializing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #76, #77, #98
This PR adds some new config options. In particular:
properUnsignedNumberSerializationwill properly serialize uint32, fixed32, uint64, fixed64 (currently we sometimes write these as negative numbers)serializeLongsAsStringwill write uint64, fixed64, sint64, sfixed64 as json string, as specified by protobuf specuseCanonicalSerializationwill enable the previous two options (and potentially more flags in the future, if new discrepancies are discovered)/cc @stevie400 @Xcelled @suruuK