fix: DIA-1523: test coverage for LabelStudioSkill #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
black made a bunch of formatting changes, ignore the ones in existing tests, there's just one big new test at the bottom |
matt-bernstein
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #247 +/- ##
==========================================
+ Coverage 65.71% 66.33% +0.62%
==========================================
Files 47 47
Lines 2424 2439 +15
==========================================
+ Hits 1593 1618 +25
+ Misses 831 821 -10 ☔ View full report in Codecov by Sentry. |
pakelley
reviewed
Nov 6, 2024
pakelley
reviewed
Nov 6, 2024
| input_field_name = ner_tag.objects[0].value.lstrip('$') | ||
| output_field_name = ner_tag.name | ||
| quote_string_field_name = 'text' | ||
| output = extract_indices(pd.concat([input, output], axis=1), input_field_name, output_field_name, quote_string_field_name) | ||
| df = pd.concat([input, output], axis=1) | ||
| output = validate_output_format_for_ner_tag(df, input_field_name, output_field_name) |
There was a problem hiding this comment.
nice, now we can take out this additional call to validate_output_format_for_ner_tag, but other than that lgtm 👍
There was a problem hiding this comment.
Still need it, I added the call to EntityExtraction.extract_indices not the standalone extract_indices
pakelley
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fuzz testing using a bunch of different label configs and models and making sure predictions are always valid
Uncovered and fixed 2 bugs: