Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1501: remove a collection of ff #6879

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented Jan 8, 2025

A group of simple FF that were stale an we dice to remove them in the same pull request to avoid the conflict when merge.

  • ff_dev_2128_html_in_labels_150422_short as True
  • ff_front_dev_2431_delete_polygon_points_080622_short as True
  • ff_front_dev_2575_projects_list_performance_280622_short as True
  • fflag_feat_front_dev_2461_audio_paragraphs_seek_chunk_position_short as True but no real code behind, looks like was a bad clean up.
  • fflag_fix_front_dev_3730_shortcuts_initial_input_22122022_short as True

All of this are LSO only.

You may want to review commit by commit and with whitespace option enabled.
First commit is empty since I create a ticket to group this work

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 71e8185
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/677fdd7628858a0008665473

Copy link

netlify bot commented Jan 8, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 71e8185
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/677fdd7628858a0008665477

@luarmr luarmr changed the title Fb optic 1501/remove a collection of ff refactor: OPTIC-1501: remove a collection of ff Jan 8, 2025
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (61e141e) to head (71e8185).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6879   +/-   ##
========================================
  Coverage    76.80%   76.80%           
========================================
  Files          171      171           
  Lines        14031    14031           
========================================
+ Hits         10776    10777    +1     
+ Misses        3255     3254    -1     
Flag Coverage Δ
pytests 76.80% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants